-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make root selectable + many other changes #1316
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fbopensource/lexical/8NQbdxhTMqbRNi3cff9ptoxDiRJZ |
cf6116c
to
53c1d1a
Compare
More changes fix e2e Ensure HR has text content
358f3e9
to
4d32c0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We should probably let the iOS folks know about these changes since they've already mimicked a good part of this selection logic
Why do we need the Bootstrap plugin for now without params? Sounds like we should make them mandatory? |
Where? |
|
I didn't change them as part of this PR did I? |
* Make root selectable More changes fix e2e Ensure HR has text content * Fix e2e test * Fix tables * See if this fixes the collab e2e tests... * Aha! * Fix some styling
This PR does quite a few things to fundamentally improve how we handle selection: