Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint fixer on repo with new sort keys rule #1210

Closed
wants to merge 4 commits into from

Conversation

justinhaaheim
Copy link
Contributor

This builds off of #1209 and fixes all the lint errors created by the new rule.

@vercel
Copy link

vercel bot commented Feb 2, 2022

@justinhaaheim is attempting to deploy a commit to the Facebook Open Source Team on Vercel.

To accomplish this, @justinhaaheim needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2022
@trueadm
Copy link
Collaborator

trueadm commented Feb 7, 2022

Unit tests are failing?

@justinhaaheim
Copy link
Contributor Author

I committed the fixes on the original branch where I added the rules. Abandoning.

@trueadm trueadm deleted the run-lint-fixer-on-repo-with-sort-keys branch April 6, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants