Refactor Decorator ref system

[trueadm]

This removes the current ref system for Decorators and replaces it with a DecoratorState system. Specifically, (for now at least), we have two types of DecoratorState - DecoratorEditor and DecoratorMap. This integrates these data structures into the existing implementations, both locally and for collaboration.

A follow up PR could introduce the DecoratorList data structure.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fbopensource/lexical/9C3xWbjF2LF9B5ZY2QDC2mNmnRAB
✅ Preview: https://lexical-git-refactor-decorator-ref-system-fbopensource.vercel.app

[zurfyx]

I think I understand the idea. I would appreciate it if you could do us a walkthrough the code, especially around the NestedEditor and CollaborationPlugin bits to be able to properly review this

[ryanisaacg]

Looks good to me but obv would like someone with more experience to actually approve. Had a bunch of questions as I read through

[ryanisaacg]

Can we 'inherit' plugins from the outer editor? (is that desirable, is it possible, etc). Just thinking about divergence in plugin support between the 'main' editor and the caption editor.

[trueadm]

I'm not sure that's too desirable as it makes things less explicit and more magical. It should be clear what plugins are being used and which ones are not. Inheriting plugins blurs that someone.

[fantactuka]

General question regarding decoratorMap: are values can only be primitives or it can be a nested map/array but it just won't be resolved granularly (recursively) between clients, and latest update will rewrite whole value?

[acywatson]

I think I understand the idea. I would appreciate it if you could do us a walkthrough the code, especially around the NestedEditor and CollaborationPlugin bits to be able to properly review this

I had the same thought - I think a walkthrough would be great. I think I get the intent, overall, though.

[trueadm]

@fantactuka only primitive values because of JSON/collab. You can nest DecoratorMap inside DecoratorMap, and once I add DecoratorList, that too. I'll need to wire up the parts more for collab, so you can look at this PR to not be definitive. More PRs to go!

[trueadm]

If anyone would like me to walk through this with them (I already did with Gerard) please schedule some time in my calendar to do so :)

[fantactuka]

If anyone would like me to walk through this with them (I already did with Gerard) please schedule some time in my calendar to do so :)

Scheduled some time tomorrow morning, if anyone else is interested - lmk I'll add to the invite

[ryanisaacg]

@fantactuka would appreciate being added to that invite!