Add stylex locally and use in playground #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
zurfyx,
shalabhvyas,
tylerjbainbridge and
acywatson
trueadm
force-pushed
the
introduce-stylex
branch
from
758d4d5 to
71ed643
Compare
facebook-github-bot
added
the
CLA Signed
trueadm
force-pushed
the
introduce-stylex
branch
from
f216722 to
6027ec1
Compare
Fix lint Fix lint Fix lint Fix lint Fix plugin
trueadm
force-pushed
the
introduce-stylex
branch
from
6027ec1 to
3de80bc
Compare
acywatson
pushed a commit
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a local copy of the stylex project to Outline's packages (as an interim solution until stylex is open sourced). For now, to keep this diff simple, we only use stylex on the Playground theme for
ltrandrtlproperties.However, it seems that we can't yet sync modules from github that use Stylex because of how the babel-plugins differ. On www they generate stylesheets at compile time, and we have no way of doing that from a sync. The best we can do, is opt certain modules to have different header modules so that they can be processed on www, but this is highly risky.