JSXTextCharacter may not be '>' or '}' either

[syranide]

See facebookarchive/esprima#36.

cc @sebmarkbage

[sebmarkbage]

Yea, can you separate the issues? :) I foresee there being more discussion on each individual part and then we can close out a whole thread individually.

[syranide]

Done, cleaned up this PR.

[sebmarkbage]

I guess this makes sense but I'd like to get input and commitment to change implementations from @RReverser and @jeffmo before pulling this in.

[RReverser]

@sebmarkbage It's no problem to change, but from @syranide's PR into esprima it looks like this also removes elements-as-attributes which conflicts with feature that we two agree on.

@syranide, is it possible to introduce these rule changes without dropping that feature (at least until further separate discussions)?

[syranide]

@RReverser Hmm? This shouldn't affect elements-as-attributes, this only rejects orphaned > and } (EDIT) in text.

[RReverser]

@syranide I'm talking about facebookarchive/esprima#36 that you mentioned in first post in this thread. As far as I can see from https://github.com/facebook/esprima/pull/36/files, in that PR you also removed element-as-attr-value from fbtest.js, so I wondered if that appeared in the same commit because those are linked issues or was there any other reason.

[syranide]

@RReverser Aha, now I see what you mean. No that is not because I "broke" elements-as-attribute but simply because that test includes an orphaned > and I just assumed that it's what it was for. I've restored the test and removed the orphaned >.

<LeftRight left=<a /> right=<b>monkeys /**>** gorillas</b> />

[sebmarkbage]

In the standards world, there's another level of stability when at least two independent implementations have implemented this.

As a guideline, we could make changes to the spec once at least two implementations have implemented the feature in their parser. What do you guys think? That shows commitment to support the feature.

[RReverser]

@sebmarkbage Sure, it's not a problem. Btw, } was already an unsupported part of JSXText in my implementation (due to implementation specifics), so just need to add >. Will do a bit later.

[sebmarkbage]

Cool. Rebase and I'll pull.