Redis support for named persistent connections

[cscd98]

Using redis with a named persistent connection will throw an exception in /hphp/system/php/redis/Redis.php in doConnect line 1500:

Named persistent connections not supported

[danslo]

Tagging @sgolemon here. Is there still a valid reason for redis being in systemlib? It would make sense for it to become a HNI module.

[cscd98]

@danslo @sgolemon I've only just started looking into this and while taking a look at php_redis persistent connections are disabled in ZTS (threaded mode) by default.

https://github.com/nicolasff/phpredis/blob/master/redis.c#L655

Are persistent connections safe with hhvm?

Persistent connections would be allowed but any that use a named connection are not:

https://github.com/facebook/hhvm/blob/master/hphp/system/php/redis/Redis.php#L1545

php_redis uses php_stream_xport_create, whereas hhvm uses pfsockopen (obviously due to different languages!)

https://github.com/nicolasff/phpredis/blob/6d14bf535548f1614d07460f0939cf5a29ec7103/library.c#L1183

Is there any reason why the code could not be refactored to make use persistent_id? either by using php_stream_xport_create or doing something with persistent_id in that class?

I am not sure why they are not supported, is it because of an issue or just because the work hasn't been done yet? Thanks

[cscd98]

@sgolemon @danslo

I am just looking at what's involved in migrating this to HNI. But I have an issue with php_stream_xport_create - it's not defined?

https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext_zend_compat/php-src/main/streams/transports.cpp#L45

unimplemented: _php_stream_xport_create

But it's used here?:

https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext_zend_compat/mongo/io_stream.cpp#L51

Also, regarding php_redis - If I was thinking about porting this instead (might not be an option time wise).. but would this be best to go in thirdparty or runtime? Also is possible to maintain an extension that is both php and hphp compatible?

There is also other c++ redis libraries out there as well, which is another possibility.

What would be the preference? Refactor hhvm's redis implementation and add on the necessary features?

[aftabnaveed]

is it supported yet, are it won't work with hhvm for now?

[cscd98]

@hamidre13 thank you