Remove float cast flag in 0.10.0 branch #654
Conversation
facebook-github-bot
added
the
CLA Signed
|
Don't have permission to approve this PR - but my build now got accepted by Apple with this PR! 👍 So this PR fixes #649 🚀 |
Summary: This breaks the open source iOS build, back it out temporarily since it doesn't have the intended effect anyway. Reviewed By: mhorowitz Differential Revision: D33290406 fbshipit-source-id: b5dbfa93a1a04e1e1b53d48b857cba867393eaaf
neildhar
force-pushed
the
remove-float-cast-flag
branch
from
6c4bb55
to
ade0f9e
Compare
neildhar
changed the title
|
has this changed also been replicated into main, btw? |
|
cool - so it's either a matter of making a 0.10.1 or a 0.11, if I'm understanding the current status of releases for Hermes. Considering that for 0.67 we ended up staying on 0.9, maybe at this point might be worth just coordinating the branch cut for 0.68 with a 0.11 for hermes? |
|
I was actually wondering whether we should just replace the artefact for the 0.10.0 CocoaPod with the patched version, given that this is a minor but necessary change for it to work. But I am currently away and haven't had a chance to think through and discuss any potential pitfalls of that approach. |
|
?? |
No description provided.