-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[circle] Build macOS CLI artefacts for arm64 #352
Conversation
@@ -196,7 +196,7 @@ jobs: | |||
|
|||
macos: | |||
macos: | |||
xcode: "10.0.0" | |||
xcode: "12.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this at all, since it is set as default above (same for some other settings like TERM)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely seems like we should be able to leverage that indeed. Before I forget this and the issue mentioned in the OP, I filed a ticket #353
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmikov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary
As noted on #345 (comment), that PR did not update the CLI artefacts to build for arm64.
I think there’s an opportunity to reduce the amount of separate builds and package both the runtime package and CLI from the same artefacts while also reducing build time, but for now I’d like to ensure the CLI tools at least also come with arm64 slices. See #353
Test Plan
Tested on a DTK machine: