Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle] Build macOS CLI artefacts for arm64 #352

Closed
wants to merge 1 commit into from

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Sep 15, 2020

Summary

As noted on #345 (comment), that PR did not update the CLI artefacts to build for arm64.

I think there’s an opportunity to reduce the amount of separate builds and package both the runtime package and CLI from the same artefacts while also reducing build time, but for now I’d like to ensure the CLI tools at least also come with arm64 slices. See #353

Test Plan

Tested on a DTK machine:

$ ditto --arch arm64 package/osx-bin/hermes package/osx-bin/hermes-arm64                 
$ file package/osx-bin/hermes-arm64                                                      
package/osx-bin/hermes-arm64: Mach-O 64-bit executable arm64
$ echo "'use strict'; function hello() { print('Hello World'); } hello();" | ./package/osx-bin/hermes-arm64 
>> Hello World
undefined
>> 

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 15, 2020
@alloy alloy changed the title [HOLD] [circle] Build macOS CLI artefacts for arm64 [circle] Build macOS CLI artefacts for arm64 Sep 15, 2020
@alloy
Copy link
Contributor Author

alloy commented Sep 15, 2020

@tmikov @Huxpro It would be good to include this before pushing out a v0.7.0 npm package.

@@ -196,7 +196,7 @@ jobs:

macos:
macos:
xcode: "10.0.0"
xcode: "12.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this at all, since it is set as default above (same for some other settings like TERM)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely seems like we should be able to leverage that indeed. Before I forget this and the issue mentioned in the OP, I filed a ticket #353

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmikov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@tmikov merged this pull request in 508f92c.

@alloy alloy deleted the build-cli-for-macos-arm64 branch September 21, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants