Disable DateTimeFormat::formatToParts for Apple platform #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50019923 |
lavenzg
added a commit
to lavenzg/hermes
that referenced
this pull request
Oct 17, 2023
Summary: DateTimeFormat::formatToParts is broken in several aspects, e.g., date components such as dayPeriod is not handled, string splitting for other locales (such as "zh-chinese") is incorrect, etc. So we have to disable it for now, and disable relevant tests. Reviewed By: neildhar Differential Revision: D50019923
lavenzg
force-pushed
the
export-D50019923
branch
from
b935ebf
to
d2f311c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50019923 |
Summary: DateTimeFormat::formatToParts is broken in several aspects, e.g., date components such as dayPeriod is not handled, string splitting for other locales (such as "zh-chinese") is incorrect, etc. So we have to disable it for now, and disable relevant tests. Reviewed By: neildhar Differential Revision: D50019923
|
This pull request was exported from Phabricator. Differential Revision: D50019923 |
lavenzg
force-pushed
the
export-D50019923
branch
from
d2f311c
to
6a0b8ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50019923 |
|
This pull request has been merged in c5a633f. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: Original Author: zhaogang@meta.com Original Git: c5a633f Original Reviewed By: neildhar Original Revision: D50019923 Pull Request resolved: #1155 DateTimeFormat::formatToParts is broken in several aspects, e.g., date components such as dayPeriod is not handled, string splitting for other locales (such as "zh-chinese") is incorrect, etc. So we have to disable it for now, and disable relevant tests. Reviewed By: tmikov Differential Revision: D50992772 fbshipit-source-id: 710b770cfd546f4bc0d6495d383fb469145e20aa
cipolleschi
added a commit
that referenced
this pull request
Jun 3, 2024
…)" This reverts commit c5a633f.
cortinico
added a commit
that referenced
this pull request
Jun 17, 2024
…)" This reverts commit c5a633f.
blakef
pushed a commit
that referenced
this pull request
Nov 12, 2024
…)" This reverts commit c5a633f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
DateTimeFormat::formatToParts is broken in several aspects, e.g.,
date components such as dayPeriod is not handled, string splitting
for other locales (such as "zh-chinese") is incorrect, etc. So we
have to disable it for now, and disable relevant tests.
Differential Revision: D50019923