Truncate legacy extension keys from default locale on iOS/Mac #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49870526 |
neildhar
added a commit
to neildhar/hermes
that referenced
this pull request
Oct 3, 2023
…ok#1141) Summary: iOS can sometimes return a default locale identifier that contains extensions in the legacy form. Ideally, we should convert these into the new style and respect them, but that isn't trivial to do. We could do also just use the iOS version of the locale without converting it. But this is potentially confusing, since the locale won't follow a format that we actually accept. So in something like: ``` Intl.Collator(Intl.Collator().resolvedOptions.locale) ``` the inner collator and outer collator will have inconsistent behaviour. For now, truncate the extensions so we can at least parse the first part of the identifier and honour it. Closes facebook#1140 Differential Revision: D49870526
neildhar
force-pushed
the
export-D49870526
branch
from
d13d0e5
to
503249e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49870526 |
…ok#1141) Summary: iOS can sometimes return a default locale identifier that contains extensions in the legacy form. Ideally, we should convert these into the new style and respect them, but that isn't trivial to do. We could do also just use the iOS version of the locale without converting it. But this is potentially confusing, since the locale won't follow a format that we actually accept. So in something like: ``` Intl.Collator(Intl.Collator().resolvedOptions.locale) ``` the inner collator and outer collator will have inconsistent behaviour. For now, truncate the extensions so we can at least parse the first part of the identifier and honour it. Closes facebook#1140 Reviewed By: avp Differential Revision: D49870526
neildhar
force-pushed
the
export-D49870526
branch
from
503249e
to
dde7c9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49870526 |
|
This pull request has been merged in 329430e. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
…#1141) Summary: Original Author: neildhar@meta.com Original Git: 329430e Original Reviewed By: avp Original Revision: D49870526 Pull Request resolved: #1141 iOS can sometimes return a default locale identifier that contains extensions in the legacy form. Ideally, we should convert these into the new style and respect them, but that isn't trivial to do. We could do also just use the iOS version of the locale without converting it. But this is potentially confusing, since the locale won't follow a format that we actually accept. So in something like: ``` Intl.Collator(Intl.Collator().resolvedOptions.locale) ``` the inner collator and outer collator will have inconsistent behaviour. For now, truncate the extensions so we can at least parse the first part of the identifier and honour it. Closes #1140 Reviewed By: tmikov Differential Revision: D50992846 fbshipit-source-id: 8acfc3a2926bf500fae35f4c2a0925c593350e3e
lunaleaps
pushed a commit
that referenced
this pull request
Nov 17, 2023
Summary: Pull Request resolved: #1141 iOS can sometimes return a default locale identifier that contains extensions in the legacy form. Ideally, we should convert these into the new style and respect them, but that isn't trivial to do. We could do also just use the iOS version of the locale without converting it. But this is potentially confusing, since the locale won't follow a format that we actually accept. So in something like: ``` Intl.Collator(Intl.Collator().resolvedOptions.locale) ``` the inner collator and outer collator will have inconsistent behaviour. For now, truncate the extensions so we can at least parse the first part of the identifier and honour it. Closes #1140 Reviewed By: avp Differential Revision: D49870526 fbshipit-source-id: 893c3e1d95009ab6b32b2e2c41ef84855cedf28a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D49870526