Ensure Hermes exits when code intentionally unreachable is reached in…

… `BCGen` Summary: This diff should kill a class of bugs we've seen with `llvm_unreachable` sometimes being misused as an assert in production and an input is able to continue execution despite failing a check or hitting a default case in a switch statement. Reviewed By: werew Differential Revision: D43513434 fbshipit-source-id: 574dedf197175e4208eaf0198a615ff491286dac
facebook · Mar 1, 2023 · a0a0365 · a0a0365
1 parent 6033ec3
commit a0a0365
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/BCGen/HBC/BytecodeDisassembler.cpp b/lib/BCGen/HBC/BytecodeDisassembler.cpp
@@ -156,7 +156,7 @@ const char *stringKindTag(StringKind::Kind kind) {
       return "i";
   }
 
-  llvm_unreachable("Unrecognised String Kind.");
+  hermes_fatal("Unrecognised String Kind.");
 }
 
 } // namespace

diff --git a/lib/BCGen/HBC/HBC.cpp b/lib/BCGen/HBC/HBC.cpp
@@ -101,7 +101,7 @@ void lowerIR(Module *M, const BytecodeGenerationOptions &options) {
   if (options.verifyIR &&
       verifyModule(*M, &llvh::errs(), VerificationMode::IR_VALID)) {
     M->dump();
-    llvm_unreachable("IR verification failed");
+    hermes_fatal("IR verification failed");
   }
 }
 

diff --git a/lib/BCGen/HBC/Passes.cpp b/lib/BCGen/HBC/Passes.cpp
@@ -535,7 +535,7 @@ bool LowerArgumentsArray::runOnFunction(Function *F) {
         }
       }
     } else {
-      llvm_unreachable("CreateArguments used for a non-Instruction.");
+      hermes_fatal("CreateArguments used for a non-Instruction.");
     }
   }
 

diff --git a/lib/BCGen/HBC/SerializedLiteralGenerator.cpp b/lib/BCGen/HBC/SerializedLiteralGenerator.cpp
@@ -100,7 +100,7 @@ void SerializedLiteralGenerator::serializeBuffer(
         newTag = NullTag;
         break;
       default:
-        llvm_unreachable("Invalid Literal Kind");
+        hermes_fatal("Invalid Literal Kind");
     }
 
     if (newTag != lastTag || seqLength == SequenceMax) {
@@ -148,7 +148,7 @@ void SerializedLiteralGenerator::serializeBuffer(
         /* no-op */
         break;
       default:
-        llvm_unreachable("Invalid Literal Kind");
+        hermes_fatal("Invalid Literal Kind");
     }
   }
   // The last value in the buffer can't get serialized in the loop.