Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color attribbute in fresco progress #2463

Open
saed220 opened this issue Feb 8, 2020 · 3 comments
Open

color attribbute in fresco progress #2463

saed220 opened this issue Feb 8, 2020 · 3 comments
Labels
bug good first issue help wanted

Comments

@saed220
Copy link

saed220 commented Feb 8, 2020

I use a vectodrwable progress that wrap in another drwable and for color of progress i use
?attr/my_attr
when I use this progress in other views every things work but when I use it in fressco the atttr color
disapear.
my vector drawble :
<path android:pathData="M23.2,43.5c-11.9,0 -21.7,-9.7 -21.7,-21.7c0,-4.1 1.2,-8.1 3.4,-11.6c0.4,-0.7 1.4,-0.9 2.1,-0.5c0.7,0.4 0.9,1.4 0.5,2.1c-1.9,3 -2.9,6.4 -2.9,10c0,10.3 8.4,18.7 18.7,18.7c0.8,0 1.5,0.7 1.5,1.5C24.7,42.8 24,43.5 23.2,43.5z" android:fillColor="?attr/my_attr"/>
@saed220
Copy link
Author

saed220 commented Mar 20, 2020 •
edited
Loading

I also get error: resurse not found exception when I use drawable that contain attribbute color .
I think problem comes from this part of code "getDrawable() " in
GenericDraweeHierarchy.java file of fresco.
I sugesct replace "getDrawable()"
with "ContextCompat.getDrawable()"
but I dont know how could I change it ?

@oprisnik
Copy link
Contributor

Hey! Yeah, right now we do not use ContextCompat unfortunately. There's also #1463 - A pull request to migrate to ContextCompat would be appreciated :)

@esafirm
Copy link
Contributor

esafirm commented Aug 10, 2020

@saed220 is there any specific way to reproduce your issue?

@realjustinwu realjustinwu mentioned this issue Feb 7, 2021
Closed
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 9, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView
429c657 
Summary:
Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provide to `Image`

Differential Revision: D59530172
@Abbondanzo Abbondanzo mentioned this issue Jul 9, 2024
Closed
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 10, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView (facebook#45354)
2d01b5c 
Summary:
Pull Request resolved: facebook#45354

Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provided to `Image`

Differential Revision: D59530172
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 12, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView (facebook#45354)
a5e0b8b 
Summary:
Pull Request resolved: facebook#45354

Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provided to `Image`

Reviewed By: javache

Differential Revision: D59530172
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 12, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView
a0087db 
Summary:
Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provide to `Image`

Differential Revision: D59530172
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 12, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView (facebook#45354)
c9b3a62 
Summary:
Pull Request resolved: facebook#45354

Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provided to `Image`

Reviewed By: javache

Differential Revision: D59530172
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 12, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView
9323260 
Summary:
Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provide to `Image`

Differential Revision: D59530172
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 12, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView (facebook#45354)
3aac1c5 
Summary:
Pull Request resolved: facebook#45354

Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provided to `Image`

Reviewed By: javache

Differential Revision: D59530172
Abbondanzo added a commit to Abbondanzo/react-native that referenced this issue Jul 12, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView
9a8ae8c 
Summary:
Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](facebook#16651), [issue](facebook#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provide to `Image`

Differential Revision: D59530172
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Jul 15, 2024
@Abbondanzo @facebook-github-bot
Support loading vector drawables in ImageView (#45354)
aad9240 
Summary:
Pull Request resolved: #45354

Fresco has indicated that they have no plans to support loading vector assets and similar drawable types in Drawee-backed views ([issue](facebook/fresco#329), [issue](facebook/fresco#1463), [issue](facebook/fresco#2463)). Guidance has been to instead load the vector drawable onto the backing image view ourselves. On the React Native side, having the ability to load vector drawables has been requested many times ([issue](#16651), [issue](#27502)).

I went this route over using a custom Fresco decoder for XML assets because vector drawables are compiled down into binary XML and I couldn't find a trivial, performant way to parse those files in a context-aware manner. This change only accounts for vector drawables, not any of the other XML-based drawable types (layer lists, level lists, state lists, 9-patch, etc.). Support could be added easily in the future by expanding the `getDrawableIfUnsupported` function.

## Changelog

[Android] [Added] - Added support for rendering XML assets provided to `Image`

Reviewed By: javache

Differential Revision: D59530172

fbshipit-source-id: 3d427c06238287e0a3b7f9570ac20e43d76126c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@esafirm @oprisnik @saed220