fix(lib/core.js): remove required @@iterator method from Iterator#6076
Closed
jedwards1211 wants to merge 1 commit intofacebook:masterfrom
Closed
fix(lib/core.js): remove required @@iterator method from Iterator#6076jedwards1211 wants to merge 1 commit intofacebook:masterfrom
jedwards1211 wants to merge 1 commit intofacebook:masterfrom
Conversation
`Iterators` are not required to be `Iterables`: http://devdocs.io/javascript/iteration_protocols > An object is an iterator when it implements a next() method with the following semantics > *Some* iterators are in turn iterables
nmote
added
the
Library definitions
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@nmote has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
Good catch, thanks |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iteratorsare not required to beIterables:http://devdocs.io/javascript/iteration_protocols