Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace __DATA_CONST with SEG_DATA_CONST #72

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Replace __DATA_CONST with SEG_DATA_CONST #72

merged 1 commit into from
Apr 20, 2020
+1 −1

Conversation

LucasXu0
Copy link
Contributor

No description provided.

@LucasXu0
Copy link
Contributor Author

I think it's not good to hard-code string __DATA_CONST.

It might be better to use an existing macro definition SEG_DATA_CONST.

@swolchok
Copy link
Contributor

Thanks!

@swolchok swolchok merged commit 8ef82f0 into facebook:master Apr 20, 2020
fengjixuchui added a commit to fengjixuchui/fishhook that referenced this pull request Apr 25, 2020
@fengjixuchui
Merge pull request #3 from facebook/master
2b7bef3 
Merge pull request facebook#72 from xurunkang/master
@jobsyu jobsyu mentioned this pull request Jun 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok Awaiting requested review from swolchok

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasXu0 @swolchok @facebook-github-bot