If hooking in __DATA_CONST, make writable before trying to write #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 13 seems to have thrown us off. Apparently, __DATA_CONST is set read-only after dyld runs.
megCanicalKb
pushed a commit
to facebook/FBRetainCycleDetector
that referenced
this pull request
Aug 20, 2019
see facebook/fishhook#65 --- Title: facebook/fishhook#65 Summary: iOS 13 seems to have thrown us off. Apparently, __DATA_CONST is set read-only after dyld runs.
|
I try this plan, on iOS 13 XR it is work. but on iOS 12 6s ,iOS13 6s it is will crash.
I want to know if I only met? |
|
@daybreak1024 this should be fixed with #66. if you could also test there that would be helpful. |
|
I think use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS 13 seems to have thrown us off. Apparently, __DATA_CONST is set read-only after dyld runs.
Fixes #61