Fix platform mapping generation test installation in GitHub Actions #872
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shiva-menta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91799530. |
shiva-menta
added a commit
to shiva-menta/fboss
that referenced
this pull request
Jan 29, 2026
…acebook#872) Summary: The platform_mapping_gen_unit_test and platform_mapping_gen_no_regression_test were failing in GitHub Actions CI with "no such file or directory" errors. The root cause was that the fboss_platform_mapping_gen CMake target was depending on the .GEN_PY_EXE internal target suffix rather than the actual target names. This prevented the add_fb_python_executable targets from being properly built and installed to the bin/ directory during the build process. Fixed by removing the .GEN_PY_EXE suffix and using the correct target names directly, which ensures the Python executables are properly installed and available for the test runner. --- > Generated by [Claude Code](https://www.internalfb.com/wiki/Confucius/Analect/Dev/Assistant/Claude_Code/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/) > [Session](https://www.internalfb.com/confucius?entry_name=Claude%20Code&mode=Focused&namespace[0]=dev&namespace[1]=assistant&session_id=968cf4cc-fd3f-11f0-9ae7-992bcc821876&tab=Chat), [Trace](https://www.internalfb.com/confucius?entry_name=Claude%20Code&mode=Focused&namespace[0]=dev&namespace[1]=assistant&session_id=968cf4cc-fd3f-11f0-9ae7-992bcc821876&tab=Trace) Differential Revision: D91799530
shiva-menta
force-pushed
the
export-D91799530
branch
2 times, most recently
from
eea2aa0 to
ba41e5b
Compare
shiva-menta
added a commit
to shiva-menta/fboss
that referenced
this pull request
Jan 30, 2026
…acebook#872) Summary: The platform_mapping_gen_unit_test and platform_mapping_gen_no_regression_test were failing in GitHub Actions CI with "no such file or directory" errors. The root cause was that the fboss_platform_mapping_gen CMake target was depending on the .GEN_PY_EXE internal target suffix rather than the actual target names. This prevented the add_fb_python_executable targets from being properly built and installed to the bin/ directory during the build process. Fixed by removing the .GEN_PY_EXE suffix and using the correct target names directly, which ensures the Python executables are properly installed and available for the test runner. --- > Generated by [Claude Code](https://www.internalfb.com/wiki/Confucius/Analect/Dev/Assistant/Claude_Code/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/) > [Session](https://www.internalfb.com/confucius?entry_name=Claude%20Code&mode=Focused&namespace[0]=dev&namespace[1]=assistant&session_id=968cf4cc-fd3f-11f0-9ae7-992bcc821876&tab=Chat), [Trace](https://www.internalfb.com/confucius?entry_name=Claude%20Code&mode=Focused&namespace[0]=dev&namespace[1]=assistant&session_id=968cf4cc-fd3f-11f0-9ae7-992bcc821876&tab=Trace) Differential Revision: D91799530
…acebook#872) Summary: The platform_mapping_gen_unit_test and platform_mapping_gen_no_regression_test were failing in GitHub Actions CI with "no such file or directory" errors. The root cause was that the fboss_platform_mapping_gen CMake target was depending on the .GEN_PY_EXE internal target suffix rather than the actual target names. This prevented the add_fb_python_executable targets from being properly built and installed to the bin/ directory during the build process. Fixed by removing the .GEN_PY_EXE suffix and using the correct target names directly, which ensures the Python executables are properly installed and available for the test runner. --- > Generated by [Claude Code](https://www.internalfb.com/wiki/Confucius/Analect/Dev/Assistant/Claude_Code/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/) > [Session](https://www.internalfb.com/confucius?entry_name=Claude%20Code&mode=Focused&namespace[0]=dev&namespace[1]=assistant&session_id=968cf4cc-fd3f-11f0-9ae7-992bcc821876&tab=Chat), [Trace](https://www.internalfb.com/confucius?entry_name=Claude%20Code&mode=Focused&namespace[0]=dev&namespace[1]=assistant&session_id=968cf4cc-fd3f-11f0-9ae7-992bcc821876&tab=Trace) Differential Revision: D91799530
shiva-menta
force-pushed
the
export-D91799530
branch
from
ba41e5b to
4c71179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The platform_mapping_gen_unit_test and platform_mapping_gen_no_regression_test were failing in GitHub Actions CI with "no such file or directory" errors. The root cause was that the fboss_platform_mapping_gen CMake target was depending on the .GEN_PY_EXE internal target suffix rather than the actual target names. This prevented the add_fb_python_executable targets from being properly built and installed to the bin/ directory during the build process. Fixed by removing the .GEN_PY_EXE suffix and using the correct target names directly, which ensures the Python executables are properly installed and available for the test runner.
Differential Revision: D91799530