Skip to content

Conversation

@dzarista
Copy link
Contributor

@dzarista dzarista commented Jan 27, 2026

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

This is the ninth PR in a series of PRs to add initial support for BLACKWOLF800BANW.

This PR adds the fan_service config for BLACKWOLF800BANW.

The config conservatively starts the fans at 70% minimum duty cycle, scaling up to 100% maximum.

PRs in this series, ordered by landing priority:

  1. BLACKWOLF800BANW: Add Initial Q4D ASIC definitions #882
  2. BLACKWOLF800BANW: Platform definition & Platform Mapping #883
  3. BLACKWOLF800BANW: BSP mapping #884
  4. BLACKWOLF800BANW: qsfp_service support #885
  5. BLACKWOLF800BANW: LED service support #886
  6. BLACKWOLF800BANW: Platform Mapping V2 #887
  7. BLACKWOLF800BANW: platform_manager support #851
  8. BLACKWOLF800BANW: sensor_service configs #852
  9. BLACKWOLF800BANW: fan_service configs #853 (THIS PR)

Landing Priority: This PR should be landed ninth.

Test Plan

Build passes when stacked on top of PRs 1-8.

Testing was also performed in an environment with all the PRs in this series combined, with the following results:
All sw_tests pass

platform_manager_hw_test pass:

[==========] Running 8 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 8 tests from PlatformManagerHwTest
[ RUN      ] PlatformManagerHwTest.ExploreAsDeployed
[       OK ] PlatformManagerHwTest.ExploreAsDeployed (39566 ms)
[ RUN      ] PlatformManagerHwTest.ExploreAfterUninstallingKmods
[       OK ] PlatformManagerHwTest.ExploreAfterUninstallingKmods (40526 ms)
[ RUN      ] PlatformManagerHwTest.ExploreAfterUnloadingKmods
[       OK ] PlatformManagerHwTest.ExploreAfterUnloadingKmods (121147 ms)
[ RUN      ] PlatformManagerHwTest.PmExplorationStatusTransitions
[       OK ] PlatformManagerHwTest.PmExplorationStatusTransitions (41180 ms)
[ RUN      ] PlatformManagerHwTest.Symlinks
[       OK ] PlatformManagerHwTest.Symlinks (39518 ms)
[ RUN      ] PlatformManagerHwTest.XcvrCtrlFiles
[       OK ] PlatformManagerHwTest.XcvrCtrlFiles (41287 ms)
[ RUN      ] PlatformManagerHwTest.XcvrIoFiles
[       OK ] PlatformManagerHwTest.XcvrIoFiles (40944 ms)
[ RUN      ] PlatformManagerHwTest.XcvrLedFiles
[       OK ] PlatformManagerHwTest.XcvrLedFiles (41487 ms)
[----------] 8 tests from PlatformManagerHwTest (405660 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 1 test suite ran. (405660 ms total)
[  PASSED  ] 8 tests.

sensor_service_hw_test pass:

[==========] Running 6 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 6 tests from SensorServiceHwTest
[ RUN      ] SensorServiceHwTest.GetAllSensors
[       OK ] SensorServiceHwTest.GetAllSensors (1055 ms)
[ RUN      ] SensorServiceHwTest.GetBogusSensor
[       OK ] SensorServiceHwTest.GetBogusSensor (1048 ms)
[ RUN      ] SensorServiceHwTest.GetSomeSensors
[       OK ] SensorServiceHwTest.GetSomeSensors (3315 ms)
[ RUN      ] SensorServiceHwTest.GetSomeSensorsViaThrift
[       OK ] SensorServiceHwTest.GetSomeSensorsViaThrift (8472 ms)
[ RUN      ] SensorServiceHwTest.SensorFetchODSCheck
[       OK ] SensorServiceHwTest.SensorFetchODSCheck (1054 ms)
[ RUN      ] SensorServiceHwTest.CheckAllSensors
[       OK ] SensorServiceHwTest.CheckAllSensors (1046 ms)
[----------] 6 tests from SensorServiceHwTest (15992 ms total)

[----------] Global test environment tear-down
[==========] 6 tests from 1 test suite ran. (15992 ms total)
[  PASSED  ] 6 tests.

fan_service_hw_test pass:

[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from FanServiceHwTest
[ RUN      ] FanServiceHwTest.TransitionalPWM
[       OK ] FanServiceHwTest.TransitionalPWM (5 ms)
[ RUN      ] FanServiceHwTest.FanControl
[       OK ] FanServiceHwTest.FanControl (114722 ms)
[ RUN      ] FanServiceHwTest.FanStatusesThrift
[       OK ] FanServiceHwTest.FanStatusesThrift (20145 ms)
[ RUN      ] FanServiceHwTest.ODSCounters
[       OK ] FanServiceHwTest.ODSCounters (13722 ms)
[ RUN      ] FanServiceHwTest.LedWriteDidNotFail
[       OK ] FanServiceHwTest.LedWriteDidNotFail (12367 ms)
[----------] 5 tests from FanServiceHwTest (160963 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (160963 ms total)
[  PASSED  ] 5 tests.

data_corral_service_hw_test pass:

[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from DataCorralServiceHwTest
[ RUN      ] DataCorralServiceHwTest.FruLedProgrammingSysfsCheck
[       OK ] DataCorralServiceHwTest.FruLedProgrammingSysfsCheck (9 ms)
[ RUN      ] DataCorralServiceHwTest.FruLEDProgrammingODSCheck
[       OK ] DataCorralServiceHwTest.FruLEDProgrammingODSCheck (8 ms)
[ RUN      ] DataCorralServiceHwTest.getCachedFruid
[       OK ] DataCorralServiceHwTest.getCachedFruid (14879 ms)
[ RUN      ] DataCorralServiceHwTest.getUncachedFruid
[       OK ] DataCorralServiceHwTest.getUncachedFruid (13504 ms)
[ RUN      ] DataCorralServiceHwTest.testThrift
[       OK ] DataCorralServiceHwTest.testThrift (13765 ms)
[----------] 5 tests from DataCorralServiceHwTest (42168 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (42168 ms total)
[  PASSED  ] 5 tests.

weutil_hw_test pass:

[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from WeutilTest
[ RUN      ] WeutilTest.getWedgeInfo
[       OK ] WeutilTest.getWedgeInfo (10544 ms)
[ RUN      ] WeutilTest.getEepromPaths
[       OK ] WeutilTest.getEepromPaths (0 ms)
[ RUN      ] WeutilTest.ValidateAllEepromContents
[       OK ] WeutilTest.ValidateAllEepromContents (21034 ms)
[ RUN      ] WeutilTest.getInfoJson
[       OK ] WeutilTest.getInfoJson (42348 ms)
[----------] 4 tests from WeutilTest (73928 ms total)

[----------] Global test environment tear-down
[==========] 4 tests from 1 test suite ran. (73928 ms total)
[  PASSED  ] 4 tests.

@meta-codesync
Copy link

meta-codesync bot commented Jan 28, 2026

@RomanChoporov-Meta has imported this pull request. If you are a Meta employee, you can view this in D91694761.

dzarista added a commit to dzarista/fboss that referenced this pull request Jan 29, 2026
This is part of a series of PRs to add support for BLACKWOLF800BANW.

This PR adds:
- Platform type definition (fboss_common.thrift, PlatformMode.h, PlatformProductInfo.cpp)
- Platform mapping (Blackwolf800banwPlatformMapping)
- SAI platform integration (SaiBcmBlackwolf800banwPlatform)

Other PRs in this series:
facebook#876 - Q4D ASIC definitions (dependency)
facebook#851 - platform_manager support
facebook#852 - sensor_service configs
facebook#853 - fan_service configs

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
dzarista added a commit to dzarista/fboss that referenced this pull request Jan 29, 2026
This is part of a series of PRs to add support for BLACKWOLF800BANW.

This PR adds:
- Platform type definition (fboss_common.thrift, PlatformMode.h, PlatformProductInfo.cpp)
- Platform mapping (Blackwolf800banwPlatformMapping)
- SAI platform integration (SaiBcmBlackwolf800banwPlatform)

Other PRs in this series:
facebook#876 - Q4D ASIC definitions (dependency)
facebook#851 - platform_manager support
facebook#852 - sensor_service configs
facebook#853 - fan_service configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant