ICECUBE800BANW: sensor_service config #846
Conversation
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this in D91696956. |
joancaneus
left a comment
joancaneus
left a comment
There was a problem hiding this comment.
Can you please look into those comments?
| "name": "CPU_DPM_POS1V05_CPU_VOUT", | ||
| "sysfsPath": "/run/devmap/sensors/CPU_DPM_UCD90320/in10_input", | ||
| "type": 1, | ||
| "thresholds": { |
There was a problem hiding this comment.
Upper and lower threshold are very tight with a 0.002V difference. Can you please double check if there is a typo there?
There was a problem hiding this comment.
The thresholds have been adjusted to the following. They are still tight, but thats expected.
"thresholds": {
"upperCriticalVal": 1.086,
"lowerCriticalVal": 1.034
},
| "name": "CPU_DPM_POS1V0_PVCCANA_CPU_VOUT", | ||
| "sysfsPath": "/run/devmap/sensors/CPU_DPM_UCD90320/in15_input", | ||
| "type": 1, | ||
| "thresholds": { |
There was a problem hiding this comment.
Another threshold that is very tight with 0.02V difference. Please ensure there is no typo there.
| "name": "CPU_DPM_POS1V8_CPU_VOUT", | ||
| "sysfsPath": "/run/devmap/sensors/CPU_DPM_UCD90320/in6_input", | ||
| "type": 1, | ||
| "thresholds": { |
There was a problem hiding this comment.
This lower and upper voltage threshold here is tight as well with 0.036V difference. Is this accurate or something you plan on changing soon?
There was a problem hiding this comment.
Yes, this has been updated and is no longer tight.
|
@aalamsi22 has updated the pull request. You must reimport the pull request before landing. |
3 participants
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This is the eighth PR in a series of PRs to add support for ICECUBE800BANW.
This PR adds the sensor_service config for ICECUBE800BANW:
PRs in this series, ordered by landing priority:
Landing Priority: This PR should be landed eighth.
Test Plan
To be added