Skip to content

[showtech] Enforce run as root and fix printGpio segfault #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huyc-arista wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

[showtech] Enforce run as root and fix printGpio segfault #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09d5643
showtech: Fix printGpio segfault on gpiod_chip_open error
huyc-arista Nov 21, 2025
ae90d70
showtech: Enforce run program as root
huyc-arista Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fboss/platform/showtech/Main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// Copyright (c) 2004-present, Meta Platforms, Inc. and affiliates.
// All Rights Reserved.
#include <unistd.h>
#include <algorithm>
#include <ranges>
#include <set>
Expand Down Expand Up @@ -103,6 +104,11 @@ int main(int argc, char** argv) {
return app.exit(e);
}

if (geteuid() != 0) {
std::cerr << "Please run this program as root" << std::endl;
return 1;
}

try {
std::string showtechConfJson =
ConfigLib(configFilePath).getShowtechConfig();
Expand Down
6 changes: 4 additions & 2 deletions fboss/platform/showtech/Utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ void Utils::printGpio(const Gpio& gpio) {
struct gpiod_chip* chip = gpiod_chip_open(gpio.path()->c_str());
for (const auto& line : *gpio.lines()) {
std::cout << fmt::format(
"line {:>3}: {:<15} -> ", *line.lineIndex(), *line.name());
"line {:>2}: {:<15} -> ", *line.lineIndex(), *line.name());
try {
std::cout << GpiodLine(chip, *line.lineIndex(), *line.name()).getValue()
<< std::endl;
Expand All @@ -471,7 +471,9 @@ void Utils::printGpio(const Gpio& gpio) {
<< std::endl;
}
}
gpiod_chip_close(chip);
if (chip) {
gpiod_chip_close(chip);
}
std::cout << std::endl;
}

Expand Down
Loading