[Accton][minipack3n] Remove Profile IDs 47 from Minipack3N platform support #723
+65
−3,936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport. Description: Profile ID 47 (PROFILE_100G_1_PAM4_RS544_OPTICAL) is not required by the Minipack3N platform PRD. This PR removes it from all relevant configuration files. Changes include: 1. CSV files: updated port_profile_mapping, profile_settings. 2. Update platform mapping JSON file for Minipack3N. 3. Updated PlatformMapping.cpp with corrected JSON format for Minipack3N.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Profile ID 47 (PROFILE_100G_1_PAM4_RS544_OPTICAL) is not required by the Minipack3N platform PRD. This PR removes it from all relevant configuration files.
Changes include:
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runAll modified files (CSV and C++) except JSON have had 'pre-commit run' executed.
The JSON file should not be included in the pre-commit run because it would cause the PMGV workflow to fail.
Summary
Test Plan
Agent HW test (T0), SAI Test (T0), and Link Test (T0) were run, producing the same results as the baseline configuration (before removing profile ID 47).