[Nexthop] getdeps must hash patches referenced by the manifest file
#702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-nexthop
changed the title
getdeps must hash patches referenced by the manifest filegetdeps must hash patches referenced by the manifest file
benoit-nexthop
force-pushed
the
getdeps-hash-patches
branch
2 times, most recently
from
f953e58 to
864c8dd
Compare
If we don’t include patches in the hash then we won’t rebuild the dependency when the patch changes.
benoit-nexthop
force-pushed
the
getdeps-hash-patches
branch
from
864c8dd to
b7f2483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
files I modified in this PR. You can install the linters by running
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
If we don’t include patches in the hash then we won’t rebuild the
dependency when the patch changes.
Test Plan
Changing a patch file now correctly causes the corresponding dependency
(and other dependencies that depend on it) to rebuild.