Skip to content

Commit

Permalink
Pull qsfp_service build into QsfpService.cmake
Browse files Browse the repository at this point in the history
Summary: Pulling the qsfp_service build out of CMakeLists.txt into the correct cmake. This also removes the conditional build for SAI_ONLY that we were doing before.

Reviewed By: simuthus-fb

Differential Revision: D42780374

fbshipit-source-id: bff73f331f6d4eddf65386d5272f3e0b87d8ad61
  • Loading branch information
Harshit Gulati authored and facebook-github-bot committed Jan 26, 2023
1 parent c3052d8 commit 5972d14
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 16 deletions.
16 changes: 0 additions & 16 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -543,14 +543,6 @@ if (NOT SAI_ONLY)
fboss/agent/platforms/wedge/oss/WedgePlatform.cpp
)

add_executable(qsfp_service
fboss/qsfp_service/QsfpServer.cpp
fboss/qsfp_service/oss/QsfpServer.cpp
fboss/qsfp_service/Main.cpp
fboss/qsfp_service/QsfpServiceHandler.cpp
fboss/qsfp_service/QsfpServiceSignalHandler.cpp
)

# TODO (skhare) refactor fboss_agent and remove this library
add_library(switch_asics_old STATIC
fboss/agent/hw/switch_asics/FakeAsic.h
Expand Down Expand Up @@ -981,14 +973,6 @@ if (NOT SAI_ONLY)

target_link_libraries(switch_asics_old fboss_agent)
target_link_libraries(wedge_agent fboss_agent)
target_link_libraries(qsfp_service
qsfp_module
fboss_agent
qsfp_config
phy_management_base
transceiver_manager
qsfp_platforms_wedge
)

add_executable(cp2112_util
fboss/util/cp2112_util.cpp
Expand Down
15 changes: 15 additions & 0 deletions cmake/QsfpService.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,18 @@ add_library(qsfp_core
target_link_libraries(qsfp_core
qsfp_handler
)

add_executable(qsfp_service
fboss/qsfp_service/Main.cpp
)

target_link_libraries(qsfp_service
qsfp_module
qsfp_config
phy_management_base
transceiver_manager
qsfp_platforms_wedge
log_thrift_call
qsfp_core
qsfp_handler
)

0 comments on commit 5972d14

Please sign in to comment.