Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fbjs] Update prepublish script to prepare #475

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[fbjs] Update prepublish script to prepare #475

merged 1 commit into from
Feb 11, 2022

Conversation

zpao
Copy link
Member

@zpao zpao commented Feb 10, 2022

Prepublish has been deprecated for a while and this footgun resulted in a 3.0.3 being published without being built.

Prepublish has been deprecated for a while and this footgun resulted in a 3.0.3 being published without being built.
Copy link
Member

@bigfootjon bigfootjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should eventually just automate releases to avoid this from ever happening

@zpao zpao merged commit 82e6f3b into main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants