Cmake build failing

[butjar]

I'm trying to get OpenR running, but I can not get an fb303 build. I hope you can help me to figure it out.

Cmake fails here:

2020-06-17T12:57:20.9023233Z CMake Error at build/fbcode_builder/CMake/FBPythonBinary.cmake:494 (add_dependencies):
2020-06-17T12:57:20.9023619Z   The dependency target "FBThrift::thrift_py.py_lib" of target
2020-06-17T12:57:20.9023761Z   "fb303_thrift_py.py_sources_built" does not exist.
2020-06-17T12:57:20.9023891Z Call Stack (most recent call first):
2020-06-17T12:57:20.9024253Z   build/fbcode_builder/CMake/FBThriftPyLibrary.cmake:104 (add_fb_python_library)
2020-06-17T12:57:20.9024424Z   build/fbcode_builder/CMake/FBThriftLibrary.cmake:63 (add_fbthrift_py_library)
2020-06-17T12:57:20.9024572Z   fb303/thrift/CMakeLists.txt:15 (add_fbthrift_library)
2020-06-17T12:57:20.9024642Z 

No idea where I can get this library from.

Full log:

2020-06-17T12:57:17.6175552Z + git clone https://github.com/facebook/fb303
2020-06-17T12:57:17.6216775Z Cloning into 'fb303'...
2020-06-17T12:57:19.7658614Z + mkdir -p /usr/local/src/fb303/_build
2020-06-17T12:57:19.7669914Z + cd /usr/local/src/fb303/_build
2020-06-17T12:57:19.7671005Z + CXXFLAGS=' -fPIC'
2020-06-17T12:57:19.7671601Z + CFLAGS=' -fPIC'
2020-06-17T12:57:19.7672055Z + cmake -DBUILD_SHARED_LIBS=ON ..
2020-06-17T12:57:19.8613933Z -- The CXX compiler identification is GNU 7.5.0
2020-06-17T12:57:19.9124339Z -- The C compiler identification is GNU 7.5.0
2020-06-17T12:57:19.9248120Z -- Check for working CXX compiler: /usr/bin/c++
2020-06-17T12:57:19.9922128Z -- Check for working CXX compiler: /usr/bin/c++ - works
2020-06-17T12:57:19.9945782Z -- Detecting CXX compiler ABI info
2020-06-17T12:57:20.0782526Z -- Detecting CXX compiler ABI info - done
2020-06-17T12:57:20.0974588Z -- Detecting CXX compile features
2020-06-17T12:57:20.0982859Z -- Detecting CXX compile features - done
2020-06-17T12:57:20.1011666Z -- Check for working C compiler: /usr/bin/cc
2020-06-17T12:57:20.1592519Z -- Check for working C compiler: /usr/bin/cc - works
2020-06-17T12:57:20.8654076Z CMake Warning (dev) at /usr/local/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
2020-06-17T12:57:20.8654449Z -- Detecting C compiler ABI info
2020-06-17T12:57:20.8658853Z   The package name passed to `find_package_handle_standard_args` (glog) does
2020-06-17T12:57:20.8659879Z   not match the name of the calling package (Glog).  This can lead to
2020-06-17T12:57:20.8660265Z -- Detecting C compiler ABI info - done
2020-06-17T12:57:20.8661104Z   problems in calling code that expects `find_package` result variables
2020-06-17T12:57:20.8661398Z -- Detecting C compile features
2020-06-17T12:57:20.8662025Z   (e.g., `_FOUND`) to follow a certain pattern.
2020-06-17T12:57:20.8662326Z -- Detecting C compile features - done
2020-06-17T12:57:20.8663394Z Call Stack (most recent call first):
2020-06-17T12:57:20.8663948Z -- Found gflags from package config /usr/lib/x86_64-linux-gnu/cmake/gflags/gflags-config.cmake
2020-06-17T12:57:20.8664798Z   build/fbcode_builder/CMake/FindGlog.cmake:17 (find_package_handle_standard_args)
2020-06-17T12:57:20.8665161Z -- Found glog: /usr/lib/x86_64-linux-gnu/libglog.so  
2020-06-17T12:57:20.8666164Z   CMakeLists.txt:35 (find_package)
2020-06-17T12:57:20.8666576Z -- Looking for pthread.h
2020-06-17T12:57:20.8667785Z This warning is for project developers.  Use -Wno-dev to suppress it.
2020-06-17T12:57:20.8668021Z -- Looking for pthread.h - found
2020-06-17T12:57:20.8668768Z 
2020-06-17T12:57:20.8669067Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
2020-06-17T12:57:20.8669762Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
2020-06-17T12:57:20.8670314Z -- Looking for pthread_create in pthreads
2020-06-17T12:57:20.8670729Z -- Looking for pthread_create in pthreads - not found
2020-06-17T12:57:20.8671126Z -- Looking for pthread_create in pthread
2020-06-17T12:57:20.8671907Z -- Looking for pthread_create in pthread - found
2020-06-17T12:57:20.8672468Z -- Found Threads: TRUE  
2020-06-17T12:57:20.8673226Z -- Found Boost: /usr/local/include (found suitable version "1.69.0", minimum required is "1.51.0") found components: context filesystem program_options regex system thread chrono date_time atomic 
2020-06-17T12:57:20.8673651Z -- Found folly: /usr/local
2020-06-17T12:57:20.8674057Z -- Check if compiler accepts -pthread
2020-06-17T12:57:20.8674453Z -- Check if compiler accepts -pthread - yes
2020-06-17T12:57:20.8674832Z -- Found FBThrift: /usr/local
2020-06-17T12:57:20.8675466Z -- Found fizz: /usr/local
2020-06-17T12:57:20.8676004Z -- Found wangle: /usr/local
2020-06-17T12:57:20.8676379Z -- Found YARPL: /usr/local
2020-06-17T12:57:20.8676750Z -- Found rsocket: /usr/local
2020-06-17T12:57:20.8896041Z -- Found Python 3: /usr/bin/python3.6
2020-06-17T12:57:20.8984834Z -- Configuring done
2020-06-17T12:57:20.9023233Z CMake Error at build/fbcode_builder/CMake/FBPythonBinary.cmake:494 (add_dependencies):
2020-06-17T12:57:20.9023619Z   The dependency target "FBThrift::thrift_py.py_lib" of target
2020-06-17T12:57:20.9023761Z   "fb303_thrift_py.py_sources_built" does not exist.
2020-06-17T12:57:20.9023891Z Call Stack (most recent call first):
2020-06-17T12:57:20.9024253Z   build/fbcode_builder/CMake/FBThriftPyLibrary.cmake:104 (add_fb_python_library)
2020-06-17T12:57:20.9024424Z   build/fbcode_builder/CMake/FBThriftLibrary.cmake:63 (add_fbthrift_py_library)
2020-06-17T12:57:20.9024572Z   fb303/thrift/CMakeLists.txt:15 (add_fbthrift_library)
2020-06-17T12:57:20.9024642Z 

[butjar]

@simpkins @wez Any clue ?

[wez]

I'm not directly intimate with either fb303 or openr, but for a number of our open sourced projects you can use the getdeps build driver which knows how to obtain and compose the build.

So something like:

$ git clone https://github.com/facebook/openr.git
$ cd openr
$ build/fbcode_builder/getdeps.py build --src-dir=. openr

I can see that openr has its own build script that doesn't use this,
which may mean that it is doing something special.
I'd suggest asking the folks in the openr project for more specific guidance!

[butjar]

@wez
Thanks for your comment.

I realized that you kind of switched from the fbcode_builder toolchain to the getdeps.py script suite. The OpenR builds using getdeps.py are failing for quite a long time with gh actions unfortunately. I'm trying to fix the failing dependencies at the moment and got stuck at fb303.

It seems that a binary with the name fb303_thrift_py.py_sources_built is missing. The cmake error came from line that git blame tells me you reviewed (FBPythonBinary.cmake:494), that's why I hoped you can help me out.

Do you have any clue how to get fb303_thrift_py.py_sources_built ?

[asljivo1]

I encountered the same issue. Is there any new information on how to resolve this?