Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file extensions and line endings #868

Closed
wants to merge 3 commits into from

Conversation

friederbluemle
Copy link
Contributor

Three related commits to fix a few file extensions/formatting. No content changes.

See discussion in #660 for some context.

cc @rightparen

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawwad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jawwad
Copy link
Contributor

jawwad commented Nov 21, 2020

@friederbluemle - What method did you use to remove the execute bit from the images? (Just wondering because these were weirdly being imported into our internal source control as empty files even though they were showing up correctly in git. Also you don't have to change anything, I think I've corrected the issue on our end).

@facebook-github-bot
Copy link
Contributor

@jawwad merged this pull request in 4fb2b1f.

@friederbluemle
Copy link
Contributor Author

@jawwad - The command I used was something like:

git ls-files 'samples/**/*.png' | xargs chmod -x

A good test on any repo is to locally run chmod -x on all files in the repo, then verify that the files that show as changed in the working directory are actually the ones that should be executable.

@jawwad
Copy link
Contributor

jawwad commented Nov 25, 2020

@friederbluemle - Cool, that's a nice tip. In that case, the issue would have been a quirk on our end since I just ended up undoing changes to the png files and then ran chmod -x on them which fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants