Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-translations): remove redundant navigation text in aria label #8842

Merged
merged 2 commits into from
Apr 6, 2023
Merged

fix(theme-translations): remove redundant navigation text in aria label #8842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dda222
fix(DocPaginator): remove redundant navigation text in aria label
dotslashtarun Mar 28, 2023
3f12e9b
docs: update localization msg for docs paginator navAriaLabel
dotslashtarun Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/src/theme/DocPaginator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default function DocPaginator(props: Props): JSX.Element {
className="pagination-nav docusaurus-mt-lg"
aria-label={translate({
id: 'theme.docs.paginator.navAriaLabel',
message: 'Docs pages navigation',
message: 'Docs pages',
description: 'The ARIA label for the docs pagination',
})}>
{previous && (
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-translations/locales/base/theme-common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"theme.docs.breadcrumbs.home___DESCRIPTION": "The ARIA label for the home page in the breadcrumbs",
"theme.docs.breadcrumbs.navAriaLabel": "Breadcrumbs",
"theme.docs.breadcrumbs.navAriaLabel___DESCRIPTION": "The ARIA label for the breadcrumbs",
"theme.docs.paginator.navAriaLabel": "Docs pages navigation",
"theme.docs.paginator.navAriaLabel": "Docs pages",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to update some of the localization messages, and for the rest that you are not sure, revert them to the English one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've updated the translations

"theme.docs.paginator.navAriaLabel___DESCRIPTION": "The ARIA label for the docs pagination",
"theme.docs.paginator.next": "Next",
"theme.docs.paginator.next___DESCRIPTION": "The label used to navigate to the next doc",
Expand Down