Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): parse Markdown headings with CRLF line break #7043

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 28, 2022

Motivation

Fix #7044

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Added two tests

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Mar 28, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2022
@netlify
Copy link

netlify bot commented Mar 28, 2022

[V2]

Name Link
🔨 Latest commit e228a7b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6241bbade0cb020008620405
😎 Deploy Preview https://deploy-preview-7043--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-7043--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 807 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 49.9 kB
website/build/assets/css/styles.********.css 105 kB
website/build/assets/js/main.********.js 613 kB
website/build/index.html 38.4 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 4f4f503 into main Mar 28, 2022
@Josh-Cena Josh-Cena deleted the jc/fix-heading branch March 28, 2022 13:59
@cp2004
Copy link

cp2004 commented Mar 29, 2022

So glad I managed to find this PR quickly! That explains some things that definitely confused me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double Title in docs
3 participants