-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix more references to Discord channels #5585
Conversation
✔️ [V2] 🔨 Explore the source changes: 6e1b002 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6145855910666a00072b0366 😎 Browse the preview: https://deploy-preview-5585--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5585--docusaurus-2.netlify.app/ |
@Josh-Cena thanks! |
The production deployment has been failing for a while I believe, unable to see any new changes to the doc. Can someone inspect that? |
Fixed that. Maybe we should set |
I think @slorber will clarify this point. |
I'd prefer to keep throwing until we have a way to report broken link errors, otherwise those could stay unnoticed (I don't think we often check for logs of successful deployments) We could extend the system to accept a function to have CI build warnings being sent to a Discord channel or something |
Is it possible to report production build status in the CI status? I have a project that uses Netlify and deployment is part of CI, so I can know if it fails through GitHub |
We have an icon on the repo readme: This is not visible enough though. Netlify has a notification system, but afaik it reports ALL failures, not just for the production branch, and it's a bit annoying. Also no Discord integration. Netlify does not provide commit statuses for the production branch, only deploy previews. |
Motivation
Missed a few places in #5581 because I used case-sensitive global search🤦♂️
Have you read the Contributing Guidelines on pull requests?
Yes