Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add stylable site to users showcase list #4441

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

tomrav
Copy link
Contributor

@tomrav tomrav commented Mar 16, 2021

Motivation

We recently transitioned our stylable.io website from jekyll over to Docusaurus and so I'm adding it to your user showcase list.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot
Copy link
Contributor

Hi @tomrav!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@tomrav tomrav changed the title added stylable site to users list docs(v2): added stylable site to users showcase list Mar 16, 2021
@netlify
Copy link

netlify bot commented Mar 16, 2021

[V1] Deploy preview success

Built with commit d7ec4eb

https://deploy-preview-4441--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 16, 2021

Deploy preview for docusaurus-2 ready!

Built with commit d7ec4eb

https://deploy-preview-4441--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 16, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4441--docusaurus-2.netlify.app/classic/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 16, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tomrav tomrav changed the title docs(v2): added stylable site to users showcase list docs(v2): add stylable site to users showcase list Mar 16, 2021
website/src/data/users.js Outdated Show resolved Hide resolved
@slorber
Copy link
Collaborator

slorber commented Mar 16, 2021

Thanks

Will just remove the tags as they don't really look appropriate for this site to me

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 16, 2021
@slorber slorber merged commit 07733e1 into facebook:master Mar 16, 2021
@tomrav tomrav deleted the add-stylable branch March 17, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants