Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add Deploy with QuandCDN #4430

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

steveworley
Copy link
Contributor

Motivation

Hi there! I've been working on a static site hosting service with a bit of a twist, we provide an interface and version control to static pages with immediate publishing/unpublishing workflow support to blend static sites with traditional dynamic content management systems.

We want to support open-source by providing the service for free to open-source projects.

We are currently using docusaurus to build our docs pages, you can see a working example:

Have you read the Contributing Guidelines on pull requests?

Yes

- Adds QuantCDN deployment target.
@facebook-github-bot
Copy link
Contributor

Hi @steveworley!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Mar 14, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 7f2e791

https://deploy-preview-4430--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 14, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 84
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4430--docusaurus-2.netlify.app/classic/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 14, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@netlify
Copy link

netlify bot commented Mar 15, 2021

@slorber
Copy link
Collaborator

slorber commented Mar 15, 2021

LGTM thanks, just remove the duplicate heading

Also please add your doc site to the showcase ;)

https://v2.docusaurus.io/showcase

@slorber slorber changed the title Update deployment.mdx docs(v2): add Deploy with QuandCDN Mar 15, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 15, 2021
@netlify
Copy link

netlify bot commented Mar 15, 2021

steveworley and others added 2 commits March 16, 2021 09:08
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
@steveworley
Copy link
Contributor Author

Thanks for the feedback @slorber! I've updated the PR to add the QuantCDN docs page to the showcase as well :) Please let me know if I can do anything else for the PR.

@slorber slorber merged commit 66e621d into facebook:master Mar 16, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 16, 2021

thanks 👍

@steveworley steveworley deleted the update-deployment-mdx branch March 17, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants