-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Add MikroORM site to showcase page #4224
Conversation
Hi @B4nan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
[V1] Deploy preview failure Built without sensitive environment variables with commit 1b26e18 https://app.netlify.com/sites/docusaurus-1/deploys/602a1c5e6c536e0008eea11f |
Size Change: 0 B Total Size: 158 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 1b26e18 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4224--docusaurus-2.netlify.app/classic/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thanks, LGTM 👍 |
Motivation
MikroORM is using docusaurus 2 for quite some time now. It uses some rather advanced features (versioning, generated api docs), so it might be a nice addition to the showcase section.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
No