-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): add fonts loaders + webpack resolve.roots #4198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[V1] Deploy preview success Built with commit c0e12b5 |
Size Change: +13 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built with commit c0e12b5 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4198--docusaurus-2.netlify.app/classic/ |
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After upgrading css-loader here: #4081
The
url(/my/font.ttf)
are not resolved by Webpack, while it was not the case before.Exemple in:
The CSS above now fails to build, because
/fonts/IRANSans5.5/IRANSansWeb_UltraLight.eot
can't be resolved (due to not resolving from the static folder, and also because there's no loader for .eot files.I think it's not a bad idea to go through the Webpack assets pipeline in such case (as it hash the assets, allowing easier/better caching) so we won't disable this, but need to keep the existing userland CSS retrocompatible.
More context discussed here: webpack-contrib/css-loader#1256
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Tested locally using a site using the CSS above:
https://github.com/massoudmaboudi/datagit_v2.docusaurus
After this change, the site can now build again after upgrading Docusaurus while it can't without this change.