Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): skip dependency install on docusaurus init #3986

Merged
merged 2 commits into from
Jan 4, 2021
Merged

feat(v2): skip dependency install on docusaurus init #3986

merged 2 commits into from
Jan 4, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 3, 2021

Motivation

Originally from #3450, support to skip install for project scaffolding.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Not required

Related PRs

None

Signed-off-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@facebook-github-bot
Copy link
Contributor

Hi @kumaraditya303!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 3, 2021

Size Change: +9 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB +2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB 0 B
website/build/main.********.js 112 kB +7 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 3, 2021

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: 91fadbe

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff189e3acd95b00071ac148

😎 Browse the preview: https://deploy-preview-3986--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 3, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Signed-off-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jan 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3986--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jan 4, 2021
@slorber slorber changed the title fix: #3450 feat(v2): skip dependency install on docusaurus init Jan 4, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 4, 2021

LGTM thanks 👍

@slorber slorber merged commit 0bb5e54 into facebook:master Jan 4, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants