-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a link to easily add your project with a form #1160
Conversation
Deploy preview for docusaurus-preview ready! Built with commit 4140cad |
@ymschaap Hi. This is actually really cool 😄 We definitely are interested in merging this, but we would need a few things first:
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ymschaap This is a really cool feature! On top of what Joel mentioned, I have the following questions:
- Are we (Babel/Docusaurus maintainers), able to configure what we ask in the form or do we have to go through you if we want to make changes?
- Many contributors want the final PR/commit made under their own name. Currently the PR is made using your bot. Can that be changed to be made using someone's GitHub account? I think the user would need to login via GitHub.
Great.
|
What are the blockers of this PR ? |
I think we are not going forward with this. Sorry. Thank you for the PR though 😉 |
Re: this discussion: #1080 (comment)
Why:
Adding a project to the users list now involves forking, editing a js file, uploading a logo, creating a PR, reviewing. Which can be made much simpler with a Github bot that transforms a form submission into the right Pull Request.
What:
This PR links to a new web based submission form from the users page: https://build.amsterdam/your-company/docusaurus
How:
As gif:
Example Bot PR:
How a bot PR looks like:
ymschaap#3
Let me know your thoughts if interested work on merging.