fix(core): fix handling of Swc html minifier warnings #10581
Merged
+105
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +349 B (0%) Total Size: 11.2 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The HTML SWC minifier diagnostic errors are too aggressive to throw
When we collect errors, we emit them as warnings with the ability to disable that warning, considering those markup errors existed before and are non-critical.
I created a troubleshooting guide for users looking to fix these warnings here: #10580
Test Plan
CI + local tests
Test links
https://deploy-preview-_____--docusaurus-2.netlify.app/