Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-translations): fix missing pluralization for label DocCard.categoryDescription.plurals #10118

Merged
merged 1 commit into from
May 9, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 9, 2024

Motivation

Fix #10098

Category card description label should display "1 item" and not "1 items"

I tried to fix many languages as well using google translate, but there could be mistakes.

I have no idea how to translate ar/fa so left them untouched.

Note I choose to not use "One item" because it does not seem better for the UX, and I'm not sure how capitalization works for each locale.

Test Plan

preview

Test links

https://deploy-preview-10118--docusaurus-2.netlify.app/tests/docs/category/tests

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 9, 2024
@slorber slorber requested a review from Josh-Cena as a code owner May 9, 2024 12:31
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 9, 2024
Copy link

netlify bot commented May 9, 2024

[V2]

Name Link
🔨 Latest commit 83b56fe
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/663cc228aa089b00099ed3f3
😎 Deploy Preview https://deploy-preview-10118--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 9, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 51 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 76 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 65 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 62 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented May 9, 2024

Size Change: 0 B

Total Size: 1.71 MB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/codeTranslations.json 2 B
website/.docusaurus/docusaurus.config.mjs 26.8 kB
website/.docusaurus/globalData.json 107 kB
website/.docusaurus/i18n.json 930 B
website/.docusaurus/registry.js 275 kB
website/.docusaurus/routes.js 179 kB
website/.docusaurus/routesChunkNames.json 119 kB
website/.docusaurus/site-metadata.json 2.17 kB
website/build/assets/css/styles.********.css 112 kB
website/build/assets/js/main.********.js 853 kB
website/build/index.html 38.1 kB

compressed-size-action

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label May 9, 2024
Copy link

argos-ci bot commented May 9, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - May 9, 2024, 1:16 PM

@slorber slorber merged commit ab9a4e7 into main May 9, 2024
34 checks passed
@slorber slorber deleted the slorber/fix-useCategoryItemsPlural branch May 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocCards incorrectly pluralise the number of elements within them when only one is present
2 participants