Skip to content

Commit

Permalink
fix(core): reapply resolve.symlinks: false
Browse files Browse the repository at this point in the history
  • Loading branch information
Josh-Cena committed Feb 4, 2022
1 parent 0c4dc00 commit 9988fb4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/docusaurus/src/webpack/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export function createBaseConfig(
resolve: {
unsafeCache: false, // not enabled, does not seem to improve perf much
extensions: ['.wasm', '.mjs', '.js', '.jsx', '.ts', '.tsx', '.json'],
symlinks: true, // see https://github.com/facebook/docusaurus/issues/3272
symlinks: false, // see https://github.com/facebook/docusaurus/pull/5126
roots: [
// Allow resolution of url("/fonts/xyz.ttf") by webpack
// See https://webpack.js.org/configuration/resolve/#resolveroots
Expand Down
4 changes: 1 addition & 3 deletions website/_dogfooding/dogfooding.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

const fs = require('fs');

/** @type {import('@docusaurus/types').PluginConfig[]} */
const dogfoodingPluginInstances = [
[
Expand All @@ -19,7 +17,7 @@ const dogfoodingPluginInstances = [

// Using a symlinked folder as source, test for use-case https://github.com/facebook/docusaurus/issues/3272
// The target folder uses a _ prefix to test against an edge case regarding MDX partials: https://github.com/facebook/docusaurus/discussions/5181#discussioncomment-1018079
path: fs.realpathSync('_dogfooding/docs-tests-symlink'),
path: '_dogfooding/docs-tests-symlink',
showLastUpdateTime: true,
sidebarItemsGenerator(args) {
return args.defaultSidebarItemsGenerator({
Expand Down

0 comments on commit 9988fb4

Please sign in to comment.