Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume the project is hosted at the root #94

Merged
merged 5 commits into from
Jul 24, 2016
+34 −8
Merged

Don't assume the project is hosted at the root #94

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0081f76
Don't assume the project is hosted at the root
dhruska Jul 22, 2016
17ced6b
Fix package.json path and add sample package.json for tests
dhruska Jul 23, 2016
24c9c9b
Update publicPath to use relative path portion of URL defined in home…
dhruska Jul 24, 2016
e2dc775
Update successful bundle generation message
dhruska Jul 24, 2016
d16a092
Show bundle generation success message based on presence of homepage …
dhruska Jul 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ var nodeModulesPath = path.join(__dirname, '..', 'node_modules');
var indexHtmlPath = path.resolve(__dirname, relativePath, 'index.html');
var faviconPath = path.resolve(__dirname, relativePath, 'favicon.ico');
var buildPath = path.join(__dirname, isInNodeModules ? '../../..' : '..', 'build');
var publicPath = require('./package.json').homepage || '/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json might not be there. I think you need to use something like path.resolve(__dirname, relativePath, 'package.json');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that, but then I run into an error that there is no package.json in the template folder. I can include a sample package.json in that folder and then the tests will successfully run - are you ok with that @gaearon ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a dummy package json there sounds reasonable to me.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK U every much, try to config package.json with "homepage":"./" make it work on default app.


module.exports = {
bail: true,
Expand All @@ -35,9 +36,7 @@ module.exports = {
path: buildPath,
filename: '[name].[chunkhash].js',
chunkFilename: '[name].[chunkhash].chunk.js',
// TODO: this wouldn't work for e.g. GH Pages.
// Good news: we can infer it from package.json :-)
publicPath: '/'
publicPath: publicPath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it’s best to infer just the path portion? e.g. stuff.com/wow should give us just /wow.
What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed - good call. Putting together a regex that could do it, but do you think there is a more elegant way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url.parse() gives you an object with pathname.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. Thanks for bearing with me. Added that, so we should now always have the path portion of the url defined in homepage, or / if it isn't defined.

},
resolve: {
extensions: ['', '.js'],
Expand Down