express.static overrides the route handler#9074
Closed
danieldunderfelt wants to merge 1 commit intofacebook:masterfrom
Closed
express.static overrides the route handler#9074danieldunderfelt wants to merge 1 commit intofacebook:masterfrom
danieldunderfelt wants to merge 1 commit intofacebook:masterfrom
Conversation
I just spend some time debugging an inexplicable error where my route handler was not being called but the site continued working. Turns out, express.static will override a `/` route when the `index.html` file is found in the static root. No server example (this included until now) of serving a CRA app has made note of this. Setting `index: false` on the static middleware turns off this behaviour and returns control to the route handler.
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just spend some time debugging an inexplicable error where my route handler was not being called but the site continued working. Turns out, express.static will override a
/route when theindex.htmlfile is found in the static root. No server example (this included until now) of serving a CRA app has made note of this. Settingindex: falseon the static middleware turns off this behaviour and returns control to the route handler.I ran into this using Express v4.17.1 and using no other Express middeware than express.static.