Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASM support #8303

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add WASM support #8303

wants to merge 1 commit into from

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Jan 9, 2020

This PR adds proper WASM support with tests

@dlech
Copy link

dlech commented Jul 6, 2020

Can you explain what you consider to be "proper" WASM support?

@sheerun
Copy link
Contributor Author

sheerun commented Jul 6, 2020

currently it just doesn't work, you can check it with test attached

@ukstv
Copy link

ukstv commented Nov 25, 2020

Hey, CRA team, could you really include this? It has been over a year already, there is a ton of useful WASM NPM packages out there and CRA still fails miserably to build it out of the box.

@ukstv
Copy link

ukstv commented Nov 25, 2020

What is missing here?

@johnleetran
Copy link

johnleetran commented Nov 30, 2020

I am in agreement with @usktv. It would be great if create-react-app works out of the box with WASM. I'm running into some painful WASM integration with my an app that was created from the create-react-app.

FYI, using a vanilla react app (without create-react-app) is really easy to use WASM and i hope it'll be easy with create-react-app generator

@parthopdas
Copy link

Hey @ianschmitz @iansu @mrmckeb @petetnt - can you please update the thread with the reason for this not getting through yet? What else needs to be done?

It is such a pain to consume wasm from CRA today.

@vestini
Copy link

vestini commented Jan 23, 2021

In fact it is true (@parthopdas) in the end a simple rule on the webpack would be enough or rather a solution in parcel style.
https://parceljs.org/webAssembly.html
Hopefully this feature will arrive soon. I'm tired of always using react-app-rewired to rewrite everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants