Skip to content

Docs: add sanitize.css as alternative in css reset docs #8267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Docs: add sanitize.css as alternative in css reset docs #8267

wants to merge 5 commits into from

Conversation

hyanmandian
Copy link

No description provided.

@facebook-github-bot
Copy link

Hi hyanmandian! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@amyrlam amyrlam self-assigned this Jan 31, 2020
oluoluoxenfree
oluoluoxenfree suggested changes Jan 31, 2020
View reviewed changes
Hyan Mandian and others added 4 commits January 31, 2020 17:28
@oluoluoxenfree
Update docusaurus/docs/adding-css-reset.md
e9897e8 
Co-Authored-By: Olu Niyi-Awosusi <o.niyiawosusi@gmail.com>
@oluoluoxenfree
Update docusaurus/docs/adding-css-reset.md
780e828 
Co-Authored-By: Olu Niyi-Awosusi <o.niyiawosusi@gmail.com>
@oluoluoxenfree
Update docusaurus/docs/adding-css-reset.md
7be2f72 
Co-Authored-By: Olu Niyi-Awosusi <o.niyiawosusi@gmail.com>
Update docusaurus/docs/adding-css-reset.md
c2b5914
@oluoluoxenfree
Copy link

Looks good to me and @amyrlam! 🙂

@ianschmitz, @iansu?

@amyrlam amyrlam added this to the 3.3.2 milestone Feb 4, 2020
@iansu iansu modified the milestones: 3.3.2, 3.4.1 Feb 14, 2020
@iansu iansu modified the milestones: 3.4.1, 3.4.2 Mar 20, 2020
gabrielbussolo
gabrielbussolo approved these changes Apr 5, 2020
View reviewed changes
Copy link

@gabrielbussolo gabrielbussolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its cool to have another reference as sanitize, looks good to me 👍

@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
@iansu
Copy link
Contributor

iansu commented May 5, 2020

Thanks for your PR but I don't think we want to start listing all the different CSS reset options that are available.

@iansu iansu closed this May 5, 2020
@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oluoluoxenfree oluoluoxenfree oluoluoxenfree requested changes

@gabrielbussolo gabrielbussolo gabrielbussolo approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees

@amyrlam amyrlam

Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@hyanmandian @facebook-github-bot @oluoluoxenfree @iansu @gabrielbussolo @amyrlam @ianschmitz