-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editor detection on WSL #8172
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
// When called via WSL, new lines are \r\r\n instead of just \r\n | ||
const wmicLineEnding = isWsl ? /\r?\r\n/g : '\r\n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why this is like that. Maybe I'm missing something here?
@iansu @mrmckeb @ianschmitz @petetnt Friendly ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @levrik, I assume this got lost during the holidays sorry.
As I understand it, the purpose of this PR is to support VSCode remote with WSL, as we already have WSL support to an extent - is that correct?
This PR is not about VS Code and WSL only. VS Code just has some special case in here because of its remote extension.
|
Thanks @levrik - I'll see if anyone on the team can test this. I'm currently on Mac and don't have WSL (although I was previously on a Surface and get that WSL is awesome). |
@mrmckeb I removed the |
The logic here is the following:
code
(orcode-insiders
) on WSL side/mnt/
we'll use the normal Windows detection with conversion of the Windows file path to a WSL file pathSeeing this in action
Inside WSL filesystem with VS Code open:
Inside Windows filesystem with Notepad++ open: