Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @testing-library to the default templates #7881

Merged
merged 9 commits into from
Oct 29, 2019
Merged

Add @testing-library to the default templates #7881

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
033a41c
add @testing-library support to the default template
Oct 25, 2019
45e46f4
use template.json
Oct 28, 2019
72fda03
fix setupTests in templates
Oct 28, 2019
dfcfc95
Fix e2e-installs dependency checks
ianschmitz Oct 29, 2019
06b2617
Fix template tests
ianschmitz Oct 29, 2019
5974d57
Update App.test.tsx
kentcdodds Oct 29, 2019
1e4aa4d
Update App.test.js
kentcdodds Oct 29, 2019
80046de
Update App.test.js
kentcdodds Oct 29, 2019
83afd9e
Update App.test.tsx
kentcdodds Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix template tests
  • Loading branch information
@ianschmitz
ianschmitz committed Oct 29, 2019
commit 06b2617a70a7b9b2ef6344d19f6e1bbe00e89b5d
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
"compile:lockfile": "node tasks/compile-lockfile.js"
},
"devDependencies": {
"@testing-library/react": "^9.3.0",
"@testing-library/jest-dom": "^4.2.0",
"@testing-library/user-event": "^7.1.2",
"alex": "^8.0.0",
"eslint": "^6.1.0",
"execa": "1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/cra-template-typescript/template/src/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ import App from './App';

test('renders welcome heading', () => {
const { getByRole } = render(<App />);
const headingElement = getByRole('heading');
expect(headingElement).toHaveTextContent(/welcome/i);
const linkElement = getByRole('link');
expect(linkElement).toHaveTextContent(/learn react/i);
});
4 changes: 2 additions & 2 deletions packages/cra-template/template/src/App.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ import App from './App';

test('renders welcome heading', () => {
const { getByRole } = render(<App />);
const headingElement = getByRole('heading');
expect(headingElement).toHaveTextContent(/welcome/i);
const linkElement = getByRole('link');
expect(linkElement).toHaveTextContent(/learn react/i);
});