-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment.md with another AWS example #7616
Conversation
Hi there, I recently wrote a long blog post that takes a React developer step-by-step through many features of AWS. I really think any beginner could follow the guide and have a production ready workflow. Please let me know if my addition is suitable for this page and thank you for all the awesome work you do.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@AndrewBestbier sorry for the delay! Looks good to me - @iansu ok with you? Haven't been active lately - ok to approve and merge with the failing Azure tests? |
Looks good. Don't worry about the failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
thanks @iansu! |
Hi there,
I recently wrote a long blog post that takes a React developer step-by-step through many features of AWS. I really think any beginner could follow the guide and have a production ready workflow. Please let me know if my addition is suitable for this page and thank you for all the awesome work you do.