Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the app name before proceeding. #628

Merged
merged 6 commits into from
Sep 11, 2016
Merged

Check the app name before proceeding. #628

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01b57c9
Check the app name before proceeding.
mareksuscak Sep 11, 2016
8aaa612
Refactor.
mareksuscak Sep 11, 2016
0669da8
Use arrow function and template string.
mareksuscak Sep 11, 2016
03a0d8a
Remove comment.
mareksuscak Sep 11, 2016
8b4f5b1
Rephrase the error.
mareksuscak Sep 11, 2016
ddff528
Add missing semicolons.
mareksuscak Sep 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove comment.
  • Loading branch information
@mareksuscak
mareksuscak committed Sep 11, 2016
commit 03a0d8a74998771d362ae0db9f7af1913110ce4e
1 change: 0 additions & 1 deletion global-cli/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ function createApp(name, verbose, version) {
var root = path.resolve(name);
var appName = path.basename(root);

// NPM is whining about installing packages with names equal to appName.
checkAppName(appName);

if (!pathExists.sync(name)) {
Expand Down