Skip to content

Fix babel preset useESModules option #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix babel preset useESModules option #6249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1899f52
Fix babel preset useESModules option
dallonf Jan 22, 2019
6fa330a
Merge pull request #1 from facebook/master
dallonf Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/babel-preset-react-app/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ module.exports = function(api, opts, env) {
// bundle size. We shouldn't rely on magic to try and shrink it.
useBuiltIns: false,
// Do not transform modules to CJS
modules: false,
// unless useESModules is false
modules: useESModules ? false : 'cjs',
// Exclude transforms that make all code slower
exclude: ['transform-typeof-symbol'],
},
Expand Down