Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about unsupported Node.js versions #575

Merged
merged 3 commits into from
Sep 6, 2016
Merged

Warn about unsupported Node.js versions #575

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fba86b0
Warn about unsupported Node.js versions
fson Sep 4, 2016
b90f6d9
Remove duplicated field and extra whitespace
fson Sep 4, 2016
8b9b8fc
Change the engine version back to 4
fson Sep 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Warn about unsupported Node.js versions 
Add the `engines` field to package.json so users of old Node.js versions
will at least get a warning when trying to install create-react-app or
react-scripts, e.g.:

  npm WARN engine create-react-app@0.3.0: wanted: {"node":">=6"} (current: {"node":"4.2.3","npm":"2.14.7"})
  • Loading branch information
@fson
fson committed Sep 4, 2016
commit fba86b07023592addf4242507aa865acac4f0463
3 changes: 3 additions & 0 deletions global-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
"bin": {
"create-react-app": "./index.js"
},
"engines": {
"node" : ">=6"
},
"dependencies": {
"chalk": "^1.1.1",
"cross-spawn": "^4.0.0",
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
"bin": {
"react-scripts": "./bin/react-scripts.js"
},
"engines": {
"node" : ">=6"
},
"dependencies": {
"autoprefixer": "6.4.0",
"babel-core": "6.14.0",
Expand Down