Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run behavioral smoke tests with Jest, add output tests #5150

Merged
merged 12 commits into from
Sep 28, 2018
Prev Previous commit
Next Next commit
Get a unique port for smoke test
  • Loading branch information
Timer committed Sep 28, 2018
commit 8509f760fa6e33fb96a4caf46849acb3d025289c
3 changes: 2 additions & 1 deletion fixtures/smoke/utils.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const execa = require('execa');
const fs = require('fs-extra');
const getPort = require('get-port');
const path = require('path');
const os = require('os');

Expand All @@ -18,7 +19,7 @@ async function isSuccessfulDevelopment({ directory }) {
['start', '--smoke-test'],
{
cwd: directory,
env: { BROWSER: 'none' },
env: { BROWSER: 'none', PORT: await getPort() },
}
);

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"eslint": "5.6.0",
"execa": "1.0.0",
"fs-extra": "^7.0.0",
"get-port": "^4.0.0",
"husky": "1.0.0-rc.15",
"jest": "^23.6.0",
"lerna": "2.9.1",
Expand Down