Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Babel to 7.0.0-rc.1 #4876

Closed
wants to merge 2 commits into from
Closed

Upgrade Babel to 7.0.0-rc.1 #4876

wants to merge 2 commits into from

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Aug 11, 2018

No description provided.

@ctrlplusb
Copy link

Really looking forward to this PR to get over some of the module resolution issues I am experiencing at the moment due to breaking changes between the Babel 7 beta versions.

@ctrlplusb
Copy link

ctrlplusb commented Aug 12, 2018 •
edited
Loading

Apologies if I am incorrect here as my knowledge is limited on these libs, but do we not have to set the useESModules flag to true as Webpack will handle module resolution/transpiling for us?

@Pajn
Copy link
Contributor

Pajn commented Aug 15, 2018

Changing usESModules or not feels like a discussion for a separate PR. It's not related to any changes in the upgraded versions

@existentialism
Copy link
Contributor

Can follow up this up with another PR, but we can get rid of explicitly adding object-rest-spread, as @babel/preset-env now has built in support for it (and will pass useBuiltIns to it appropriately).

@shai32
Copy link

shai32 commented Aug 22, 2018

https://twitter.com/left_pad/status/1031700991186489344

@zhuangya
Copy link

and now babel 7 is released :)

http://babeljs.io/blog/2018/08/27/7.0.0
http://babeljs.io/docs/en/v7-migration

@zhuangya zhuangya mentioned this pull request Aug 28, 2018
Closed
Timer added a commit to Timer/create-react-app that referenced this pull request Sep 19, 2018
@Timer
Upgrade to Babel 7
5120bdc 
Closes facebook#4932, Closes facebook#4876
@Timer Timer mentioned this pull request Sep 20, 2018
Merged
@Timer Timer closed this in #5042 Sep 20, 2018
Timer added a commit that referenced this pull request Sep 20, 2018
@Timer
Upgrade to Babel 7 stable (#5042)
0bdbe42 
Closes #4932, Closes #4876
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@Timer
Upgrade to Babel 7 stable (facebook#5042)
d6fc23a 
Closes facebook#4932, Closes facebook#4876
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
@iansu iansu deleted the babel-7-rc-1 branch October 18, 2019 05:53
LishuGupta652 pushed a commit to LishuGupta652/create-react-app-1 that referenced this pull request Oct 8, 2024
@Timer
Upgrade to Babel 7 stable (facebook#5042)
9858267 
Closes facebook#4932, Closes facebook#4876
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Pajn Pajn Pajn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iansu @ctrlplusb @Pajn @existentialism @shai32 @zhuangya @facebook-github-bot