Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opt-out for prestet-flow to work with @babel/preset-typescript #3865

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

oieduardorabelo
Copy link
Contributor

@oieduardorabelo oieduardorabelo commented Jan 19, 2018

related to #3863,

now you can make babel-preset-react-app@next work nicely with @babel/preset-typescript:

{
  "presets": [
    ["react-app", {
        "flow": false 
    }],
    "@babel/typescript"
  ]
}

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 2.0.0 milestone Jan 19, 2018
@gaearon gaearon merged commit d67a9e7 into facebook:next Jan 19, 2018
@vidup
Copy link

vidup commented Jan 30, 2018

The fix isn't in the last "next" release (4.0.0-next.9754a231) of babel-preset-react-app. It's on the repo (indeed merged as we can see here), but not in the published npm package. Is it intended for later ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants